Conversation
|
https://www.npmjs.com/package/@kylecarbs/http-parser-js is published if anyone would like to use the fix immediately! |
|
For some reason the tests have been sitting "queued" for a day and not running, and I'm not sure they'd even catch this, but... I'm guessing this change will break anyone using the library on any other version of Node, as you're now not passing parameters that are previously expected. Taking a quick look, I think just changing it to always pass |
|
@Jimbly will do in a bit! |
This was broken by: nodejs/node@b970634
|
@Jimbly fixed! |
|
Not sure why the automated tests aren't running, but I was able to manually run them (Node v16, Python 2.7) and all passed, so, looks good! |
|
Published to NPM as v0.5.9 |
This was broken by: nodejs/node@b970634