Open
Conversation
special
commented
Aug 8, 2020
CreateCollation registers a Go function as a sqlite collation, similar to CreateFunction. These can be used in queries for custom sorting.
AdamSLevy
reviewed
Jun 18, 2022
Collaborator
AdamSLevy
left a comment
There was a problem hiding this comment.
Looks good. minor changes please:
- use RWMutex
- Remove conn from xcollation
|
|
||
| x := &xcollation{ | ||
| name: name, | ||
| conn: conn, |
Collaborator
There was a problem hiding this comment.
I don't think a collation ever needs to know its own conn actually.
| } | ||
|
|
||
| var xcollations = struct { | ||
| mu sync.Mutex |
Collaborator
There was a problem hiding this comment.
Please make this a sync.RWMutex
Comment on lines
+98
to
+100
| xcollations.mu.Lock() | ||
| x := xcollations.m[int(ptr)] | ||
| xcollations.mu.Unlock() |
Collaborator
There was a problem hiding this comment.
Suggested change
| xcollations.mu.Lock() | |
| x := xcollations.m[int(ptr)] | |
| xcollations.mu.Unlock() | |
| xcollations.mu.RLock() | |
| x := xcollations.m[int(ptr)] | |
| xcollations.mu.RUnlock() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.