Skip to content

updated entrypoint.sh to enable capi port overriding#104

Merged
ceejatec merged 1 commit intocouchbase:masterfrom
dharanikesav:override-capi-port
Jun 20, 2018
Merged

updated entrypoint.sh to enable capi port overriding#104
ceejatec merged 1 commit intocouchbase:masterfrom
dharanikesav:override-capi-port

Conversation

@dharanikesav
Copy link
Contributor

@dharanikesav dharanikesav commented Jun 7, 2018

Earlier, it was not possible to override capi port using environment variables. So, code for overriding capi port is added to entrypoint.sh and now, its possible to override capi port.

@tleyden
Copy link
Contributor

tleyden commented Jun 18, 2018

@dharanikesav thanks for the PR.

@ceejatec any reason not to accept this change? I'll volunteer to regenerate from templates.

@ceejatec
Copy link
Contributor

ceejatec commented Jun 19, 2018

No, I've got no objection. And yes, @dharanikesav , thank you!

@dharanikesav
Copy link
Contributor Author

dharanikesav commented Jun 20, 2018

@tleyden @ceejatec welcome.. Is it ok to merge this branch?

@ceejatec ceejatec merged commit 1856b44 into couchbase:master Jun 20, 2018
@ceejatec
Copy link
Contributor

ceejatec commented Jun 20, 2018

Went ahead and merged it. I'll regenerate the templates shortly. I'll also re-create the couchbase/server Docker Hub image for the most recent tags. The official "couchbase" image won't get updated until our next release.

Thanks again for the change!

@dharanikesav dharanikesav deleted the override-capi-port branch June 21, 2018 06:10
ceejatec added a commit to ceejatec/docker that referenced this pull request Jul 17, 2018
@ceejatec
MB-30496: Revert "updated entrypoint.sh to enable capi port overridin…
ad1f06c 
…g" (couchbase#104)

This change unfortunately had several problems which resulted in serious
regressions. Reverting this change. If we need to support CAPI_PORT for
overriding, we will need to do it more carefully.
ceejatec added a commit that referenced this pull request Jul 17, 2018
@ceejatec
MB-30496: Revert "updated entrypoint.sh to enable capi port overridin…
86e665b 
…g" (#104) (#109)

This change unfortunately had several problems which resulted in serious
regressions. Reverting this change. If we need to support CAPI_PORT for
overriding, we will need to do it more carefully.
@ceejatec
Copy link
Contributor

ceejatec commented Jul 17, 2018

FYI @dharanikesav I had to revert this change as it was breaking core functionality. See https://issues.couchbase.com/browse/MB-30496 for details.

At the moment we don't intend to re-introduce this ability. If you wanted to re-propose something I will take a look, but I can't be sure we'll have the testing time to validate it. Apologies.

@dharanikesav
Copy link
Contributor Author

dharanikesav commented Jul 18, 2018

@ceejatec Sorry, it was my bad. I fixed this issue as part of new branch and created a new pull request. "update override capi-port implementation #106". Kindly merge this. This should solve the problem of unnecessary overriding of capi port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dharanikesav @tleyden @ceejatec