Make krun_start_enter error when root directory does not exist#150
Draft
mtjhrc wants to merge 2 commits intocontainers:mainfrom
Draft
Make krun_start_enter error when root directory does not exist#150mtjhrc wants to merge 2 commits intocontainers:mainfrom
mtjhrc wants to merge 2 commits intocontainers:mainfrom
Conversation
Previously krun_start_enter would succeed and the guest kernel would just panic. The root filesystem directory was opened lazily when the guest kernel used fuse init opcode. This commit changes it so the root directory is opened when creating the fs device. This only fixes it on Linux, but not in the macOS implementation. Signed-off-by: Matej Hrica <mhrica@redhat.com>
Collaborator
Author
|
@slp I fixed it in the macOS implementation too. I don't know if it works, but it compiles with |
…xist Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
fs-early-fail
branch
from
0ef6c80 to
0ddaf3c
Compare
Collaborator
Author
Member
|
Is this still in progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously krun_start_enter would succeed and the guest kernel would just panic. The root filesystem directory was opened lazily when the guest kernel used fuse init opcode.
This commit changes it so the root directory is opened when creating the fs device.
This only fixes it on Linux, but not in the macOS implementation.