refactor(codegen): remove dead maxFieldDepth code and enforce trailing commas#697
Open
pyramation wants to merge 18 commits intomainfrom
Open
refactor(codegen): remove dead maxFieldDepth code and enforce trailing commas#697pyramation wants to merge 18 commits intomainfrom
pyramation wants to merge 18 commits intomainfrom
Conversation
…copy patterns - Convert queries.ts, mutations.ts, custom-queries.ts, custom-mutations.ts from lines.push() string concatenation to Babel AST generation - Convert client.ts and selection.ts from string template literals to template-copy pattern - Add hooks-ast.ts shared helper library for Babel AST node construction - Add template files: hooks-client.ts, hooks-selection.ts - Add AGENTS.md with codegen rules (AST-only, no string concat, templates as files) - Update test snapshots for Babel formatting changes (whitespace/formatting only)
…-browser-compatible - Add hyphenateKeys, flattenDbFields, buildDbConfig, seedArgvFromConfig, buildGenerateOptions to shared.ts as generic reusable utilities - Replace manual cliOverrides/hasNonInteractiveArgs with prompt->camelize->generate flow - Remove deprecated --browser-compatible flag from CLI, config types, and generate - Simplify both CLI entry points (graphql/codegen/src/cli, packages/cli) - Update test mocks to match new shared utility imports
- Remove all defaultSelect constants and overload 2 (without fields) from all hook generators - Remove buildDefaultSelectExpr, buildSelectFallbackExpr, buildDefaultSelectLiteral, getDefaultSelectFieldName - Remove withoutFieldsSelectionType, withoutFieldsListSelectionType, NON_SELECT_TYPES_AST - Remove buildDefaultSelectExpression from ORM custom-ops-generator - Remove defaultSelect/defaultRef from ORM model-generator - Make selection with fields required in all hook and ORM method signatures - Update 25 snapshots to reflect removed overloads
…utationId default)
…ve ignores; separate examples job)
…t-codegen-app build to build:app
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(codegen): remove dead maxFieldDepth, enforce trailing commas, clean CI
Summary
Three changes bundled together:
1. Dead code removal —
maxFieldDepthconfig optionRemoved
maxFieldDepthfrom the config type, defaults, and the entire pipeline (index.ts→custom-queries.ts/custom-mutations.ts). The only consumer wasgetSelectableFields()intype-resolver.ts, which had zero callers anywhere in the codebase — it was leftover from the old default-select system that was removed in PR #694.skipQueryFieldis retained becauseshouldSkipField()still has active callers.2. Trailing comma enforcement on
graphql/codegen/src/Ran Prettier with
--trailing-comma allacross the codegen package source. This is formatting-only — no logic changes. 2 snapshots updated (template output now includes trailing commas in generated type definitions). No Prettier/ESLint config files were committed per user request.3. CI & workspace cleanup (carried from prior commits on this branch)
test-codegen-app's"build"→"build:app"sopnpm -r run buildskips it (it requires live API codegen)package.jsonbuild scripts to cleanpnpm -r run build(no--filter '!'hacks)run-tests.yamlanddocker-launchql.yamlto removepaths-ignoreand negated filter workaroundsexamples/codegen-integrationprivate package with dedicated CI workflowmakageto0.1.12across workspace (fixesENOTEMPTYrace condition infs.rm)Review & Testing Checklist for Human
getSelectableFieldsis truly dead — search the codebase for any callers ofgetSelectableFieldsthat may have been missed. This was an exported function; downstream consumers outside the monorepo could theoretically depend on it.custom-queries.ts,custom-mutations.ts,mutations.ts,hooks-ast.ts) to confirm no logic was accidentally changed.skipQueryFieldis still actively used — it was kept in the config whilemaxFieldDepthwas removed. VerifyshouldSkipField()has real callers to justify keeping it.pnpm buildfrom clean state — ensure thebuild:apprename doesn't cause issues and the workspace builds cleanly without filters.Recommended test plan:
Notes
examples-integrationworkflow runs codegen against a fixture schemaLink to Devin run: https://app.devin.ai/sessions/a93d427c49214dce877d1fedee950c04
Requested by: @pyramation