chore(ci): add examples/codegen-integration package and clean up CI workflows#696
Open
pyramation wants to merge 17 commits intomainfrom
Open
chore(ci): add examples/codegen-integration package and clean up CI workflows#696pyramation wants to merge 17 commits intomainfrom
pyramation wants to merge 17 commits intomainfrom
Conversation
…copy patterns - Convert queries.ts, mutations.ts, custom-queries.ts, custom-mutations.ts from lines.push() string concatenation to Babel AST generation - Convert client.ts and selection.ts from string template literals to template-copy pattern - Add hooks-ast.ts shared helper library for Babel AST node construction - Add template files: hooks-client.ts, hooks-selection.ts - Add AGENTS.md with codegen rules (AST-only, no string concat, templates as files) - Update test snapshots for Babel formatting changes (whitespace/formatting only)
…-browser-compatible - Add hyphenateKeys, flattenDbFields, buildDbConfig, seedArgvFromConfig, buildGenerateOptions to shared.ts as generic reusable utilities - Replace manual cliOverrides/hasNonInteractiveArgs with prompt->camelize->generate flow - Remove deprecated --browser-compatible flag from CLI, config types, and generate - Simplify both CLI entry points (graphql/codegen/src/cli, packages/cli) - Update test mocks to match new shared utility imports
- Remove all defaultSelect constants and overload 2 (without fields) from all hook generators - Remove buildDefaultSelectExpr, buildSelectFallbackExpr, buildDefaultSelectLiteral, getDefaultSelectFieldName - Remove withoutFieldsSelectionType, withoutFieldsListSelectionType, NON_SELECT_TYPES_AST - Remove buildDefaultSelectExpression from ORM custom-ops-generator - Remove defaultSelect/defaultRef from ORM model-generator - Make selection with fields required in all hook and ORM method signatures - Update 25 snapshots to reflect removed overloads
…utationId default)
…ve ignores; separate examples job)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…t-codegen-app build to build:app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore(ci): add examples/codegen-integration package, clean up CI workflows
Summary
Introduces a private
examples/codegen-integrationworkspace package that exercises the graphql codegen pipeline against the example schema — without any workflow hacks, build filter exclusions, orpaths-ignoreblocks.What changed
examples/codegen-integration— private package that callsgenerate()directly (no interactive CLI) againstgraphql/codegen/examples/example.schema.graphql, producing React Query hooks + ORM client output. Has nobuildscript, sopnpm -r run buildnaturally skips it.examples-integration.yamlworkflow — triggers on PRs touchingexamples/**orgraphql/codegen/**; runspnpm run buildthentest:codegen.test-codegen-appbuild→build:app— the Vite test app's build requires generated code from a live API (gitignoredsrc/generated/), so it can't participate in workspace-wide builds. Renamed sopnpm -r run buildskips it cleanly instead of needing negated--filterexclusions.pnpm-workspace.yaml— addedexamples/*ENOTEMPTYrace condition in clean)What was explicitly NOT changed (matching main)
run-tests.yamlbuild step remainspnpm run build— zero filter hacksdocker-launchql.yaml— nopaths-ignoreblocks addedpackage.json—"build": "pnpm -r run build"— zero filter exclusionsReview & Testing Checklist for Human
test-codegen-appbuild→build:apprename has no side effects — check that no other script, workflow, orDockerfilereferencespnpm run buildfor this package. Theanalyze:visualscript callsvite builddirectly, so it should be unaffected.codegen-runner.ts— the runner importsgenerate()via../../../graphql/codegen/src/core/generate. This is fragile if the package moves. Consider whether importing from the built package (@constructive-io/graphql-codegen) would be more robust.CLAUDE.mdreformatting is intentional — large documentation restructuring is included but unrelated to CI cleanup. Consider splitting if not desired.Suggested test plan:
pnpm install && pnpm buildat the repo root — should complete with no errors and no filter exclusionspnpm -r --filter @constructive-io/examples-codegen-integration run test:codegen— should generate code successfully against the fixture schemaNotes
The
test:typesscript in the examples package will currently fail due to pre-existing type errors in the generated code. CI only runstest:codegenwhich verifies codegen generation succeeds.Link to Devin run: https://app.devin.ai/sessions/a93d427c49214dce877d1fedee950c04
Requested by: @pyramation