normalize copy plugin. Fixes #166

[azhang]

No description provided.

[stephenmathieson]

this looks weird; why not just use basename defined at L14?

[azhang]

Not sure why I did that. Removed L14.

[yields]

would be good to not require() inside a function, since it's sync ?

[stephenmathieson]

@yields shouldn't matter, as path has been required multiple times areadly in this file

[yields]

oh yeah, i know require()'s are cached :) just looks weird IMHO haha

[stephenmathieson]

yeah looks very weird i agree

[azhang]

Okay I’ve moved it.
-- 
Aaron Zhang

On March 10, 2014 at 3:28:49 PM, Stephen Mathieson (notifications@github.com) wrote:

In lib/plugins/copy.js:

@@ -62,3 +63,19 @@ module.exports = function(type, dest, opts){
batch.end(done);
};
};
+
+
+/**

• * Normalize conf name.
• * @param {Object} conf
• * @param {Array} list
• * @return {String}
• * @api private
• */
  +
  +function normalize(conf, list){
• return conf == list[0]
• ? conf.name
• : require('path').basename(conf.path());
  yeah looks very weird i agree

—
Reply to this email directly or view it on GitHub.