Make nested brackets optimization more effective again#418
Merged
Conversation
robinst
commented
Jan 14, 2026
| // - Collapsed: `[foo][]` (foo is both the text and label) | ||
| // - Shortcut: `[foo]` (foo is both the text and label) | ||
|
|
||
| String text = scanner.getSource(opener.contentPosition, beforeClose).getContent(); |
Collaborator
Author
There was a problem hiding this comment.
In the nestedBackets test, the opener.bracketAfter && textIsReference && opener.markerNode == null is true, but calculating this is slow and unnecessary. Move it down to where we actually need it.
Collaborator
Author
There was a problem hiding this comment.
(This happened with the link parsing rework for footnotes.)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=========================================
Coverage 94.58% 94.58%
Complexity 333 333
=========================================
Files 147 147
Lines 4838 4839 +1
Branches 698 698
=========================================
+ Hits 4576 4577 +1
Misses 141 141
Partials 121 121
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PathologicalTest#nestedBracketsstarted failing on CI sometimes. This fixes it.