Fix #862. Properties with required modifier should be required.#863
Open
Orace wants to merge 3 commits intocommandlineparser:masterfrom
Open
Fix #862. Properties with required modifier should be required.#863Orace wants to merge 3 commits intocommandlineparser:masterfrom
required modifier should be required.#863Orace wants to merge 3 commits intocommandlineparser:masterfrom
Conversation
Orace
changed the title
required modifier should be required.
| private class Options | ||
| { | ||
| [Option("cols")] | ||
| public required int Cols { get; set; } |
There was a problem hiding this comment.
What if you have a required modifier and [Option(Required = false)]? I would say, it should throw because of conflicting settings. Please add test for such case
Author
Comment on lines
+118
to
+122
| #if NET7_0_OR_GREATER | ||
| var isRequired = attrs.OfType<RequiredMemberAttribute>().Any(); | ||
| #else | ||
| var isRequired = false; | ||
| #endif |
There was a problem hiding this comment.
Suggested change
| #if NET7_0_OR_GREATER | |
| var isRequired = attrs.OfType<RequiredMemberAttribute>().Any(); | |
| #else | |
| var isRequired = false; | |
| #endif | |
| var isRequired = false; | |
| #if NET7_0_OR_GREATER | |
| isRequired = attrs.OfType<RequiredMemberAttribute>().Any(); | |
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #862