Update project to get proper ESM export and tests.#27
Update project to get proper ESM export and tests.#27ScreamZ wants to merge 1 commit intocolyseus:masterfrom
Conversation
|
Hi @ScreamZ, thank you for the pull-request. I'm afraid ESM support is already working since the package rename here: 07fb476 I think the real issue is that I am hesitant to add so many new dependencies as history has shown keeping up-to-date with a number of different tools only adds burden to maintaining such simple package as |
The change consists on two changes, first change to clock (colyseus/clock#3) then to timer (this one) I can understand your fears and respect them. I just wanted to share what I've done. So I'll probably make my own fork on npm as I can't use the library right now 😅 I would be pleased to use more things from colyseus, but I've migrated to a simpler protocol to implement without compilation for my IoT Server Kit. I'm already taking a lot of inspiration of your work, thanks! And I contribute whenever i can ;) |
|
So @endel any plan on merging that, or you rather prefer if I publish my own fork of this to support true ESM, both are ok for me |
Warning
Do not merge until clock is released, as it depends on it and i need to update depencies for 1.1
Ping me when ready.
@endel Had issue with your ESM code, so i rewrote full clock and timer (as they depends on each others.)
They both works in commonJS and ESM.
Added CI checks with github workflows
Based on work from totaltypescript.com/how-to-create-an-npm-package