Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements improvements to timeout handling and error response handling for the network client. Key changes include updating print method signatures to include const qualifiers, adding a buildDefaultResponse helper to centralize error responses based on HTTP status codes, and revising the non-blocking connection logic in the client.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/messages/response.cpp | Updated print() signature with const qualifiers to support functional const correctness. |
| src/messages/request.cpp | Similar update to print() for consistency. |
| src/helpers/client.cpp | Added buildDefaultResponse and enhanced error/timeout handling in the send() method. |
| src/client/client.cpp | Revised non-blocking connect() using fcntl, select, and improved timeout settings. |
| include/mochios/messages/*.h | Updated method declarations to match the new const-qualified print() signature. |
| include/mochios/client/options.h | Added a timeout field to the Connection struct simplifying timeout configuration. |
| example/main.cpp | Updated error handling in the main driver code to capture and report connection issues. |
|
Build successful! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14