Support floating strategy and named portals for editable links #2358
+66
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow ActionButtons to use fixed positioning via a floatingStrategy prop passed to useFloating. Support portal="aboveNavigationWidgets" to render action buttons in the high z-index portal used by hotspot tooltips. Turn linkPreviewFloatingStrategy into a general floatingStrategy prop on EditableLink so it applies to both the link tooltip and the action buttons.
tf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow ActionButtons to use fixed positioning via a floatingStrategy prop passed to useFloating. Support portal="aboveNavigationWidgets" to render action buttons in the high z-index portal used by hotspot tooltips.
Turn linkPreviewFloatingStrategy into a general
floatingStrategy prop on EditableLink so it applies to both the link tooltip and the action buttons.