Fix wheel animation for zero-crossing and countdown #2356
Merged
+155
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor useWheelCharacters to properly handle animations that cross zero (both directions) and countdown scenarios. Extract digit animation logic into createDigitCharFunction for cleaner code. Leading zeros now stay hidden until the wheel rotates past the backside, and zeros remain hidden when counting down since they become leading zeros. REDMINE-21218
The minus sign now appears when the displayed value is actually negative. For integers, this is at -1; for 1 decimal place, at -0.1. Previously the minus was hidden until -1 regardless of decimal places. REDMINE-21218
Decimal values like 0.7 were displayed incorrectly because dividing by 0.1 produces 6.999... instead of 7. Multiply by integer (10, 100) instead of dividing by fraction (0.1, 0.01) since integer multiplication is exact. REDMINE-21218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor useWheelCharacters to properly handle animations that cross zero (both directions) and countdown scenarios. Extract digit animation logic into createDigitCharFunction for cleaner code.
Leading zeros now stay hidden until the wheel rotates past the backside, and zeros remain hidden when counting down since they become leading zeros.
REDMINE-21218