Issue 67 add upcoming events to landing page carousel#86
Open
Issue 67 add upcoming events to landing page carousel#86
Conversation
laurenpudz
requested review from
SafetyInObscurity and
samjjacko
and removed request for
samjjacko
laurenpudz
reviewed
Feb 7, 2026
Contributor
There was a problem hiding this comment.
why has this been added? is it being used anywhere? if it is not being used we should remove it
| </Link> | ||
| {!isEmpty && ( | ||
| <Link href="/events" className="font-jersey10"> | ||
| <Button>See More {`>`}</Button> |
Contributor
There was a problem hiding this comment.
We should not be using a > character here. Please just leave it without the > for now
| text="The easiest way to get involved is to come along to one of our events!" | ||
| /> | ||
| </div> | ||
| </div>1 |
Comment on lines
+16
to
+40
| function formatEventDateDisplay(dateString: string): string { | ||
| try { | ||
| const date = new Date(dateString); | ||
| const weekday = new Intl.DateTimeFormat("en-US", { | ||
| weekday: "long", | ||
| }).format(date); | ||
| const day = new Intl.DateTimeFormat("en-US", { day: "numeric" }).format( | ||
| date, | ||
| ); | ||
| const month = new Intl.DateTimeFormat("en-US", { month: "short" }).format( | ||
| date, | ||
| ); | ||
| const time = new Intl.DateTimeFormat("en-US", { | ||
| hour: "2-digit", | ||
| minute: "2-digit", | ||
| hour12: true, | ||
| }) | ||
| .format(date) | ||
| .replace("AM", "am") | ||
| .replace("PM", "pm"); | ||
| return `${weekday} ${day} ${month} ${time}`; | ||
| } catch { | ||
| return ""; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do we already have a function to do this from the event pages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
[Briefly summarise the changes that you made. Just high-level stuff]
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
[Is there anything in particular in the review that I should be aware of?]
Related issue