This repository was archived by the owner on May 9, 2020. It is now read-only.
NodeAttributes.to_dict now does a recursive merge#75
Open
ryanohnemus wants to merge 1 commit intocoderanger:masterfrom
ryanohnemus:fixes/node_attributes_shallow_merge
Open
NodeAttributes.to_dict now does a recursive merge#75ryanohnemus wants to merge 1 commit intocoderanger:masterfrom ryanohnemus:fixes/node_attributes_shallow_merge
ryanohnemus wants to merge 1 commit intocoderanger:masterfrom
ryanohnemus:fixes/node_attributes_shallow_merge
Conversation
Author
|
@coderanger would you be able to give any feedback? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from #64: if "postgresql" is set on the default level to {"version": "9.5"} and on the normal level to {"enable_pgdg_apt": true}, then the "postgresql" key in the output of to_dict() would have the value of {"enable_pgdg_apt": True} instead of {"enable_pgdg_apt": True, "version": "9.5"}
With this change, you should now get a properly merged dictionary showing
{"enable_pgdg_apt": True, "version": "9.5"}fixes #64
I didn't see a contributing doc, so let me know if I need to change anything else... ie setup.py version, etc