C2LC-433: Add keyboard shortcut for pen down toggle#231
Open
chosww wants to merge 3 commits intocodelearncreate:develop-1.0from
Open
C2LC-433: Add keyboard shortcut for pen down toggle#231chosww wants to merge 3 commits intocodelearncreate:develop-1.0from
chosww wants to merge 3 commits intocodelearncreate:develop-1.0from
Conversation
Contributor
|
The code changes look reasonable, but the preview deployment failed, so I didn't perform any QA. |
Contributor
|
I performed QA on a local checkout of the branch. It works as expected on all browsers. I specifically tested using the key binding while the program is playing, which works the same as if you'd toggled the pen up/down using a keyboard or mouse. This is ready for further review as far as I can see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See C2LC-433 for details.