Fix router template of scaffold generator for models with name compose of more than 1 word#65
Open
tyraeltong wants to merge 1 commit intocodebrew:masterfrom
Open
Fix router template of scaffold generator for models with name compose of more than 1 word#65tyraeltong wants to merge 1 commit intocodebrew:masterfrom
tyraeltong wants to merge 1 commit intocodebrew:masterfrom
Conversation
…e is composed of more than 1 word.
|
I faced the same issue with multiple word model names as well. The fix mentioned here seems to work. Might be a good idea to merge this in? |
|
+1 for merging this |
|
+1 as well. Please merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One example:
the router gets generated would be like:
While it should stick to camel name convention for js code, use testCase instead of test_case. And there're some other part of the code is using something like options.testCases but here you passed in test_case hence the problem like 'bind' is not a function on 'undefined' would happen.