checkbox checked prop AND not binding to elements without name attr#27
Open
jotto wants to merge 2 commits intocodebrew:masterfrom
jotto:master
Open
checkbox checked prop AND not binding to elements without name attr#27jotto wants to merge 2 commits intocodebrew:masterfrom jotto:master
jotto wants to merge 2 commits intocodebrew:masterfrom
jotto:master
Conversation
Author
|
sorry this is kind of a mess, i didn't intend for the gemspec file to be a part of the pull request, just datalink.js |
…d adds a check to ensure there's a value on the name attribute of an element before binding to an event (otherwise any input without a name attr will bind to change:undefined). another way of handling this might be using $(":input[name]") instead of $(":input"). either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see commits for more detail