Make sync compatible with Rails' strong parameters#189
Open
jarrett wants to merge 1 commit intocodebrew:masterfrom
Open
Make sync compatible with Rails' strong parameters#189jarrett wants to merge 1 commit intocodebrew:masterfrom
jarrett wants to merge 1 commit intocodebrew:masterfrom
Conversation
|
bump |
Collaborator
|
thanks for the PR, I will have a look at this and merge it over this weekend. Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry to change the sync monkey-patch so much. I didn't want to be more intrusive than necessary with this fix. But because Backbone's
syncandsavemethods are so monolithic, there wasn't a way for me to address this issue with a more targeted patch.