Open
Conversation
…cript also included a pure-javascript demo component
also regenerated demo with new files
|
@sinisterchipmunk work was no longer merging due to a minor conflict, I've merged his work with the latest master it's available here |
|
Except my merge isn't working, and I'm uncertain why -- I have just started using Backbone The problem appears to be within the index_view at this call:
However, it's not the real problem. Inspect this object vs master (vanilla) the object is not subclassing properly. I think some CoffeeScript magic isn't getting triggered |
|
Bump!! Any hope of getting this added to the project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests adds support for generating pure JavaScript code instead of CoffeeScript code. It also removes the hard dependency on CoffeeScript, allowing Rails apps to make use of this gem without requiring CoffeeScript as a dependency. (For my own case, this also allows me to use a version of CoffeeScript that this project's
gemspecwould otherwise prohibit.)The generators can produce pure JavaScript by explicitly passing
--javascript, or implicitly by simply omitting CoffeeScript from theGemfile.This pull request addresses #46. It also adds a pure JavaScript component to the demo.
It is thoroughly tested.