Add support for (decaffeinated) JavaScript?#121
Open
teleological wants to merge 4 commits intocodebrew:masterfrom
Open
Add support for (decaffeinated) JavaScript?#121teleological wants to merge 4 commits intocodebrew:masterfrom
teleological wants to merge 4 commits intocodebrew:masterfrom
Conversation
|
Hi @teleological, Hi @ryanfitz I noticed the same behavior and would really appreciate to see this merged. Thanks, ben |
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
Contributor
|
I love coffeescript, but the change is easy enough so I 👍 |
|
+1 |
Contributor
|
@teleological could make this PR against http://westonplatter.com/railsy_backbone? I'd love to add it to the repo. |
Collaborator
|
@teleological can you please update this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables backbone-rails generators to produce JavaScript when the javascript_engine generator option is set to :js. Coffee-rails sets javascript_engine to :coffee, although it can be overridden in an initializer:
Is this something you'd be interested in merging?