Fix auth login logic: avoid password rehashing and token-gated auth#1902
Open
dipok-1 wants to merge 1 commit intocode100x:mainfrom
Open
Fix auth login logic: avoid password rehashing and token-gated auth#1902dipok-1 wants to merge 1 commit intocode100x:mainfrom
dipok-1 wants to merge 1 commit intocode100x:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple login-related issues and improves the reliability of the authentication flow.
Notes
trim(), the 401 error still occurs.bcrypt.compareonly.appxAuthTokenrequirement from password validation so login depends only on identity and password.useStateinstead ofuseRefto prevent stale input values during authentication.These changes improve the correctness, stability, and predictability of the login flow.
Note (Infrastructure)
During local testing, authentication failures were traced to Prisma failing to initialize due to a missing database configuration:
When this happens, NextAuth masks the underlying error and returns a
CredentialsSignin (401)response even when the provided credentials are valid.This is an environment/runtime configuration issue and is not addressed in this PR.