Add Linter (golang-ci) and address fixes#113
Open
mfycheng wants to merge 8 commits intocode-payments:mainfrom
Open
Add Linter (golang-ci) and address fixes#113mfycheng wants to merge 8 commits intocode-payments:mainfrom
mfycheng wants to merge 8 commits intocode-payments:mainfrom
Conversation
Contributor
mfycheng
commented
Apr 13, 2024
mfycheng
commented
- Adds golang-ci setup
- Adds default linters + revive+whitespace (with some exceptions)
- Fixes issues detected by the above.
var-naming has a _huge_ amount of conflicts (3k+) due to the use of Id initialism instead of ID (and to a lesser extent, URL, HTTP, and a few SCREAMING_SNAKE_CASES). unused-param has a bunch laying around too that would add some noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.