Modified topOffset option and added $.scrollIt.destroy() function to remove event handlers#35
Open
mphasize wants to merge 3 commits intocmpolis:masterfrom
Open
Modified topOffset option and added $.scrollIt.destroy() function to remove event handlers#35mphasize wants to merge 3 commits intocmpolis:masterfrom
mphasize wants to merge 3 commits intocmpolis:masterfrom
Conversation
…that object’s properties so we can adjust the offsetTop nicely in responsive layouts. Yeah! :-)
…t.listeners object to expose event handlers.
Using an object for topOffset we can change that value during the page views lifecycle, which makes responsive webdesigns a little easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Modified the topOffset option to accept an object with { val : 0 }. The way Javascript works, this enables us to keep a variable outside of scrollIt like this:
This modification is pretty useful, when you want to create responsive layouts in combination with scrollIt.
Second change: I added a function to remove the scrollIt event handlers. This is quite useful when building a single page app or using frameworks like Ember, so that you can cleanly remove scrollIt and re-initialize it when you move around the page.
Use
$.scrollIt.destroy()Cheers!