fix(ENG-2912): CLI typos and doc changes#154
Open
ralph-mcteggart wants to merge 6 commits intomasterfrom
Open
Conversation
Collaborator
|
@ralph-mcteggart Your tests are (false positive) timing out because they're waiting for |
Author
Cheers @chrisimcevoy! Was aware but haven't got round to fixing it. Appreciate the heads up though 😁 |
|
Code Climate has analyzed commit 99e0d00 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 71.5% (0.0% change). View more on Code Climate. |
MrTam
approved these changes
Dec 15, 2023
dgonzalez
approved these changes
Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was originally looking here for a defect related to the CLI before realising the required changes were in the API.
When reading through the docs I noticed some inconsistencies so updated while I was here
(ENG-2912)