Skip to content

Conversation

@mxschll
Copy link
Member

@mxschll mxschll commented Feb 6, 2026

Description

This PR refactors the children prop of the Dropdown component to be named content, aligning its API with other components such as Tooltip and Popover.

Related

[Quip proposal: RGJgABPXohP8RGJgABPXohP8]

How has this been tested?

Unit tests and regression tests are green.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (9a1b7c5) to head (ec7b3dd).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4229   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         886      886           
  Lines       26006    26008    +2     
  Branches     9419     9422    +3     
=======================================
+ Hits        25276    25278    +2     
+ Misses        724      683   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ernst-dev
ernst-dev previously approved these changes Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants