Open
Conversation
AmazingDreams
force-pushed
the
feature/wkhtmltoimage
branch
from
6ee7307 to
06e8323
Compare
Author
|
I think this implementation is more or less final now. I tested it using publishLocal in another project and it all works. It's weird how the tests ran directly don't work (wkhtmltoX doesn't return) but the tests & code I run in that project work fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created an implementation for wkhtmltoimage, but was unable to test because wkhtmltopdf/image seems to be hanging in the tests.
Please review and comment about anything.
Basically I just copied and pasted the Pdf and PdfConfig classes and changed some strings here and there. I could simplify the implementation by simply extending those classes and only overriding
findExecutable. But I can't test this, so this'll have to do for now.