Option to treat control sequences as 0 width #20
Merged
+341
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an IgnoreControlSequences option to treat ANSI/control-sequence graphemes as zero-width, leveraging updated uax29 grapheme parsing.
Changes:
- Add
Options.IgnoreControlSequencesand wire it into grapheme iteration forString/Bytes. - Treat multi-byte grapheme clusters that start with a C0 control byte as width 0.
- Bump
github.com/clipperhouse/uax29/v2dependency tov2.6.0and add tests for ANSI sequences.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| width.go | Adds new option, forwards it to the grapheme iterator for width calculation, and adjusts width logic for C0-led multi-byte graphemes. |
| width_test.go | Adds tests asserting zero width for ANSI/control sequences when the new option is enabled. |
| go.mod / go.sum | Updates uax29 dependency to v2.6.0. |
| comparison/go.mod / comparison/go.sum | Keeps comparison module dependency graph in sync with updated uax29 version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
IgnoreControlSequencesoption to treat escape sequences as zero width. The actual meaningful change is inuax29, which will parse the sequences as single graphemes. Then indisplaywidthwe simply check the leading character as being C0.