You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is great, thanks Kiana! Some things to figure out, which I can handle this week:
Currently, there is a separate GitHub action push-gh-pages.yml that actually deploys the site to the gh-pages branch and is triggered on any change to website/public. We can have this new action just commit the built site to website/public and keep the other action as-is to actually deploy the site, OR we can combine the two so that this action both builds the site and pushes to gh-pages.
Whether or not we want to keep the built website/public folder is a separate decision, though I am partial to keeping it. Because of how the gh-pages branch is set up, there is no history there, so the only way to currently see the actual changes and historical state of the published site is in the website/public directory history (or otherwise by checking out the repo for a given commit and compiling locally). This kind of historical archive is nice but not a big deal to get rid of IMO since change history is at least described in website/src.
We should add some sort of status check / branch protection to prevent people from modifying website/public / gh-pages (and perhaps restrict them to only be modified via GitHub action). See Add branch protection for gh-pages #3. Does not need to be addressed by this PR.
I would like to add a README.md to the root repo or possibly the website repo to document how these actions work and how to update the site (and the broader docs). See Write docs on how to update the docs #54, also does not have to be addressed by this PR.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.