Possible Buffer overflow: add length checks to header creation#51
Open
McRoot12 wants to merge 2 commits intocisco:mainfrom
Open
Possible Buffer overflow: add length checks to header creation#51McRoot12 wants to merge 2 commits intocisco:mainfrom
McRoot12 wants to merge 2 commits intocisco:mainfrom
Conversation
|
est_server_http.c changes should use hdrlen, not hdr_len |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
est_client.c:
When the generated header is bigger than EST_HTTP_HDR_MAX the
will result in a memory corruption, because of http_data + hdr_len
est_server.c
snprintf() should check how much space is left in the header