Skip to content

Makes passing the 'rustToolchain' optional when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix#60

Merged
OpsBotPrime merged 1 commit intomasterfrom
nix-make_setting_rustToolchain_optional
Feb 6, 2026
Merged

Makes passing the 'rustToolchain' optional when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix#60
OpsBotPrime merged 1 commit intomasterfrom
nix-make_setting_rustToolchain_optional

Conversation

@Qqwy
Copy link
Contributor

@Qqwy Qqwy commented Feb 6, 2026

Makes passing the 'rustToolchain' optional when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix.

They can still be overridden by specifying a different Rust version in the overlay. But if kept at its default, will use the version from the rust-toolchain.toml in the opsqueue repo itself.

By making this optional, users of the library do not need to care about which Rust version they are using. Except that if they are using a particular version for other parts of their software, they can ensure they use the same (to prevent building deps twice, for example).

when using pkgs.callPackage to build opsqueue.nix or opsqueue_python.nix

They can still be overridden by specifying a different Rust version in
the overlay. But if kept at its default, will use the version from the
`rust-toolchain.toml` in the opsqueue repo itself.
@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 6, 2026

@OpsBotPrime merge

@OpsBotPrime
Copy link
Contributor

Your merge request has been denied, because merging on Fridays is not recommended. To override this behaviour use the command merge on Friday.

@Qqwy
Copy link
Contributor Author

Qqwy commented Feb 6, 2026

@OpsBotPrime merge on Friday

@OpsBotPrime
Copy link
Contributor

Rebased as 87d250d, waiting for CI …

@OpsBotPrime
Copy link
Contributor

CI job 🟡 started.

@OpsBotPrime OpsBotPrime merged commit 87d250d into master Feb 6, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants