Open
Conversation
…nd chamilo-lms -1.11.x, this file is only processed at docker build, still need to find out how to everride its content when using dockr run =/
…p instructions to get some errors, I've also changed the host and domain used by the current example.
…es, file include ARG instructions to override some values that were before hardcoded, still need to find out how to make the env variables override values when issuing docker run. This file downloads chamilo, composer and chash from github and then performs composer update producing a 3.5GB size docker image. I'm going to summit another pull request that avoids this steps. Finally openssh its removed , docker exec -it ${container_name} /bin/bash could be used in the docker host to get into the running container. Entrypoint inmplemented so container can run in detached mode
…ust use one downloaded pron githubs repo =)
Author
|
Somehow I keep missing the right target branch to merge |
Member
|
No need to close and reopen PRs. If you just update the branch (from which you sent the PR) on your repo, it will update the PR automatically ;-) |
…uded composer and php-fpm from ubuntu apt repositories
Author
Thakns for the tip, still learning to the right way to contribute ;-) |
Redirected git clone to a fork and branch of chamilo/chamilo-lms in my personal repository, this forked project intruduces a few configuration and programming changes that help me get chamilo-lms up and running on a docker container and authenticating users against our OpenLDAP service.
tag name replaced by the correct one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to match Dockerfile with README file