ENT-9531: Added reports for enterprise users to migrate db retention settings#2525
Open
nickanderson wants to merge 1 commit intocfengine:masterfrom
Open
ENT-9531: Added reports for enterprise users to migrate db retention settings#2525nickanderson wants to merge 1 commit intocfengine:masterfrom
nickanderson wants to merge 1 commit intocfengine:masterfrom
Conversation
This change is intended to ensure that customizations users have made related to data retention are migrated to the new location where cf-reactor can make use of them. Ticket: ENT-9531 Changelog: Title
nickanderson
commented
Oct 24, 2022
| { | ||
| classes: | ||
| "running_binary_with_new_db_retention_settings" | ||
| expression => "cfengine_3_22_0|feature_cf_reactor_report_retention"; |
Member
Author
There was a problem hiding this comment.
This was just a WAG for the context. Ideally, we will have a non version based class to key off of for this.
Contributor
There was a problem hiding this comment.
Yeah, maybe a feature class? Or something similar.
Member
Author
There was a problem hiding this comment.
Yeahp, I like the thought of a feature class.
Member
Author
|
Tagged WIP because this doesn't need to be prioritized for release and it may change based on other implementation details no yet determined. |
vpodzime
approved these changes
Oct 25, 2022
Contributor
vpodzime
left a comment
vpodzime
left a comment
There was a problem hiding this comment.
ACK. We will see how things evolve before this is needed.
nickanderson
added
onhold
olehermanse
requested changes
Nov 28, 2022
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
👍 , but don't merge until needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to ensure that customizations users have made related to
data retention are migrated to the new location where cf-reactor can make use of them.
Example output when retention settings have been modified:
Ticket: ENT-9531
Changelog: Title