CFE-413: set_variable_values_ini for values with equal sign#1873
CFE-413: set_variable_values_ini for values with equal sign#1873ncharles wants to merge 1 commit intocfengine:masterfrom
Conversation
nickanderson
left a comment
nickanderson
left a comment
There was a problem hiding this comment.
Unsure about the breakage it introduces, will need to dig a bit deeper, but I do think we should try and avoid the explicit restriction to second pass, surely there is something we can fix to make that un-necessary.
| select_region => INI_section(escape("$(sectionName)")), | ||
| classes => results("bundle", "set_variable_values_ini_not_$(cindex[$(index)])"), | ||
| if => "edit_$(cindex[$(index)])"; | ||
| "pass2" expression => "pass1"; |
There was a problem hiding this comment.
Ewwwww. Why are you forcing a specific pass restriction?
Presumably, something isn't yet defined or hasn't been completed. Or, not able to select region until the second pass?
There was a problem hiding this comment.
Exactly. If it's on the first pass, if the section doesn't exist yet, it cannot select the region, and fails. It won't reevaluate at the 2nd pass
There was a problem hiding this comment.
Right, but since the promise to insert the section is before the promise to set key values for the region, it should be able to select it during the same pass.
2 participants
Allow equal sign in set_variable_values_ini