CFE-4623: Test that findfiles() returns directories with a trailing slash when given a trailing slash#6007
Open
nickanderson wants to merge 1 commit intocfengine:masterfrom
Open
CFE-4623: Test that findfiles() returns directories with a trailing slash when given a trailing slash#6007nickanderson wants to merge 1 commit intocfengine:masterfrom
nickanderson wants to merge 1 commit intocfengine:masterfrom
Conversation
…given a trailing slash Prior to findfiles() fixes related to https://cfengine.com/blog/2025/change-in-behavior-findfiles/ findfiles() would return a trailing slash for directories when one was provided. This behavior was expected by users, but not tested for explicitly nor documented as an explicit behavior. Ticket: CFE-4623 Changelog: None
nickanderson
force-pushed
the
CFE-4623/master
branch
from
2c721ed to
f702d3b
Compare
|
Thank you for submitting a pull request! Maybe @larsewi can review this? |
larsewi
requested changes
Jan 7, 2026
| classes: | ||
|
|
||
| "ok" | ||
| expression => regcmp( ".*[\\]$", $(test.find_this_promise_dirname) ); |
Contributor
There was a problem hiding this comment.
From GitHub Actions:
error: Regular expression error: 'missing terminating ] for character class' in expression '.*[\]$' (offset: 6)
I think what is happening here is that \\ becomes \, then the ] gets escaped.
I'm not sure if you need a character set (i.e., []) here at all, since you're only matching one character.
|
Marking this PR as stale due to inactivity; it will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to findfiles() fixes related to
https://cfengine.com/blog/2025/change-in-behavior-findfiles/ findfiles() would
return a trailing slash for directories when one was provided.
This behavior was expected by users, but not tested for explicitly nor
documented as an explicit behavior.
Ticket: CFE-4623
Changelog: None