feat: improvements in embed mode #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diocas
reviewed
Feb 3, 2026
| } | ||
| if (unref(isEmbedModeEnabled) && !unref(isFilePicker)) { | ||
| if (unref(isEmbedModeEnabled)) { |
There was a problem hiding this comment.
why? isFilePicker is true if the target is file, which is what we want, no? I see use cases to embed and allow users to download or open files.
Author
There was a problem hiding this comment.
the embed method does not allow users to open files (https://github.com/cernbox/web/blob/cernbox/packages/web-pkg/src/composables/actions/files/useFileActions.ts#L113-L115)
In upstream, this added later on the file picker and I didn't manage to find a reason why.
I removed it to avoid downloading a file when clicking on its name.
The download via context menu or buttons is still available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
targetOriginconfigurable via URI for integration with extenal services (ex: indico and codimd)