Open
Conversation
cbalona
requested changes
May 23, 2025
Collaborator
cbalona
left a comment
There was a problem hiding this comment.
Hi Adam, thanks very much for the changes. Happy with them. I did have failed tests on py3.13 with chainladder<0.8.20 however. I plan to do a review of the full codebase this year and fix some deepre issues. We can limit python to <3.13 for now until then. I also agree with adding to pypi with the limitation on chainladder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functional changes in these files
These and several other files also have whitespace changes created by
black.Added
sparse<0.16totox.ini, which has tradeoffspyproject.tomland publish to PyPI immediately.