Add skip_bmc_config parameter to create_machine to skip re-config of BMC#294
Add skip_bmc_config parameter to create_machine to skip re-config of BMC#294acormier1 wants to merge 1 commit intocanonical:masterfrom
Conversation
SK1Y101
left a comment
There was a problem hiding this comment.
The changes look alright, though the MAAS API docs do suggest this parameter is an integer rather than a boolean https://git.launchpad.net/maas/tree/src/maasserver/api/machines.py#n2039, so we may need to do some testing
This parameter is also passable to the commissioning stage of a Machine, extending to include that may be useful.
fcfbbd0 to
b29f064
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #294 +/- ##
==========================================
- Coverage 69.43% 69.43% -0.01%
==========================================
Files 76 76
Lines 6024 6026 +2
Branches 1347 1348 +1
==========================================
+ Hits 4183 4184 +1
Misses 1612 1612
- Partials 229 230 +1 ☔ View full report in Codecov by Sentry. |
|
Linter isn't happy, could you run |
The create_machine API in Maas supports a
skip_bmc_configflag. When set to true, this flag skips the bmc config so that a new user is not created. This is a workaround for some lenovo BMC's which have an issue during this provisioning step.The result in maas when providing this parameter:
