changing input data structure for multiple var extaction#173
Draft
richagadgil wants to merge 1 commit intodevfrom
Draft
changing input data structure for multiple var extaction#173richagadgil wants to merge 1 commit intodevfrom
richagadgil wants to merge 1 commit intodevfrom
Conversation
|
Your Render PR Server URL is https://nimbus-pr-173.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-bra2vah8vr2d92lo8e60. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Your Render PR Server at https://nimbus-pr-173.onrender.com is now live! View it on your dashboard at https://dashboard.render.com/web/srv-bra2vah8vr2d92lo8e60. |
Member
|
I know this is a WIP PR and not ready to be reviewed - I noticed the server is 500'ing when asked a simple question (like 'What is Foaad's email?'). Might be worth looking into before you do too many other changes since it'll be easier to narrow down the fewer changes there are. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's New?
Adding support for multiple variable extraction.
The new JSON returned from
variable_extractor/extract_variableslooks like:{
entities: List of Entities,normalized question: question with all entities extracted,input question: raw question}
entitiesis a list of JSONS in the following format:{
entity: entity,tag: tag,normalized entity: normalized entity,normalized entity question: question normalized for ONLY this entity}
Let's take an example...
question = "When is CSC 202 taught by Workman?"
{
entities: [{entity: 'CSC 202',tag: 'COURSE',normalized entity: 'CSC 202',normalized entity question: 'When is [COURSE] taught by Workman?'}, {entity: 'Workman',tag: 'PROF',normalized entity: 'Workman',normalized entity question: 'When is CSC 202 taught by [PROF]?'}],normalized question: 'When is [COURSE] taught by [PROF]?',input question: 'When is CSC 202 taught by Workman?'}
Has been tested with the edge condition of NO entities found.
Works with NLP classifier code, which just looks for
normalized questionin the top level of the JSON structure.Type of change (pick-one)