Merged
Conversation
First step towards removing some of the work we do when updating plugin versions. This simply looks for the latest plugin version that already exists in the plugins directory, and bumps the `deps:` key to the latest version for plugins. I _don't_ think this handles the case where the update to a dep is in the same PR as the update to the consuming plugin (I think the syncer can handle that case?), so we could maybe extend this further to detect that situation. I think we can also go further and start to look for updates to certain deps (e.g., a gRPC runtime package) on registries.
Member
Author
|
This is specifically targeting this sort of update: #2241 (comment) |
stefanvanburen
added a commit
that referenced
this pull request
Feb 6, 2026
In #2242, I mentioned: > I don't think this handles the case where the update to a dep is in the same PR as the update to the consuming plugin (I think the syncer can handle that case?), so we could maybe extend this further to detect that situation. This attempts to handle that situation, by refactoring the fetcher a little bit: we first take a pass to grab all the pending updates, and then subsequently run the updates (in dependency order), updating the `latestPluginVersions` as we go so that consumers can be updated with the latest dependency. This just needed a tiny bit of tweaking to have an "integration" test over `run` (making the fetcher an interface), so added that as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First step towards removing some of the work we do when updating plugin versions. This simply looks for the latest plugin version that already exists in the plugins directory, and bumps the
deps:key to the latest version for plugins.I don't think this handles the case where the update to a dep is in the same PR as the update to the consuming plugin (I think the syncer can handle that case?), so we could maybe extend this further to detect that situation.
I think we can also go further and start to look for updates to certain deps (e.g., a gRPC runtime package) on registries.