Add support for changing the file's mode#49
Closed
hildjj wants to merge 1 commit intobruce:masterfrom
Closed
Conversation
|
+1 |
UziTech
suggested changes
Apr 25, 2019
Contributor
UziTech
left a comment
UziTech
left a comment
There was a problem hiding this comment.
If this was rebased I would approve it
harrysarson
suggested changes
Apr 25, 2019
| if ((rawAffixes == null) || (rawAffixes.mode == null)) { | ||
| return 0600; | ||
| } | ||
| return parseInt(rawAffixes.mode) || 0600; |
There was a problem hiding this comment.
Possibly, getMode() should throw and error if rawAffixes is not an integer rather than silently failing here.
Although, if this library has a precedence of not throwing on parameter validation then ignore me.
hildjj
added a commit
to hildjj/node-temp
that referenced
this pull request
Apr 26, 2019
Author
|
See #82 for a rebase, with tests. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running as root, I needed the ability to make a temp file available to non-root users.
This patch adds a
modeaffix that sets the permissions of the file to whateverthe caller wants. The default is still 0600, so there is no change in interface.