perf: no need to create a new array and new anonymous function#3572
Open
cesco69 wants to merge 4 commits intobrianc:masterfrom
Open
perf: no need to create a new array and new anonymous function#3572cesco69 wants to merge 4 commits intobrianc:masterfrom
cesco69 wants to merge 4 commits intobrianc:masterfrom
Conversation
charmander
reviewed
Dec 16, 2025
Collaborator
charmander
left a comment
charmander
left a comment
There was a problem hiding this comment.
This calls end/emits removes in a different order, which is probably fine – but it’s also a real microoptimization, especially compared to some of the other stuff the pool does…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this._idle.slice().map( ... )create a new array and new anonymous function every time