Open
Conversation
charmander
requested changes
Oct 8, 2024
Collaborator
charmander
left a comment
charmander
left a comment
There was a problem hiding this comment.
Thanks for the bug fix in the serializer.
Tests?
| const len = reader.int32() | ||
| // a -1 for length means the value of the field is null | ||
| fields[i] = len === -1 ? null : this.reader.string(len) | ||
| fields[i] = len === -1 ? null : textMode ? reader.string(len) : reader.bytes(len) |
Collaborator
There was a problem hiding this comment.
Should this use the field’s mode?
The constructor also still has
if (opts?.mode === 'binary') {
throw new Error('Binary mode not supported yet')
}
Collaborator
There was a problem hiding this comment.
Agreed that mode is incorrect here.
This may be fixed by #3495
hjr3
reviewed
Jun 29, 2025
| const columnFormatCount = 0 | ||
| writer.addInt16(columnFormatCount) | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.