Added support for input devices/streams and tests#178
Open
Omar-Riaz wants to merge 2 commits intobramp:masterfrom
Open
Added support for input devices/streams and tests#178Omar-Riaz wants to merge 2 commits intobramp:masterfrom
Omar-Riaz wants to merge 2 commits intobramp:masterfrom
Conversation
Author
|
Updated test to support device_number. Is it ok to include the parameter if there are no duplicates and it is set to zero? |
Owner
|
Thanks for the PR. I'm on vacation for the next week, so I won't look at this until later next week. Feel free to ping me if I don't respond next week. |
Author
|
Hi @bramp , did you get a chance to review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a subclass called
FFMpegInputBuilderwhich extends theAbstractFFmpegStreamBuilder. Seeing that theAbstractFFmpegInputBuilderwas designed for outputs, I re-implemented the filename property and build method to retain all previous functionality.I also added tests to see that the inputs are built properly, modelled after #156 . I added a convenience method to parse commands separated by spaces for assertion purposes.
From the
FFmpegBuilder, you simply calladdInputStream(String inputStream)to build the input.