Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 322aaa996c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| overrideModel: z.string().nullish(), | ||
| overrideSystemPrompt: z.string().nullish(), |
There was a problem hiding this comment.
Renaming custom_model/custom_system_prompt to camelCase here introduces a breaking read path for existing secrets: BaseMetadataSchema is .strict(), so metadata objects that still contain the old keys are now rejected by APISecretSchema.parse during secret lookup (packages/proxy/edge/index.ts:244-249), which drops into the fallback branch and uses the bearer token as a provider key (packages/proxy/edge/index.ts:260-265). In environments with previously saved snake_case metadata, this can turn valid proxy credentials into provider auth failures until every stored secret is migrated.
Useful? React with 👍 / 👎.
2 participants
We already have
customModelsand adopt camel case for consistency