Open
Conversation
Member
Author
Member
|
This PR has too many unrelated changes so I didn't feel comfortable applying it. Instead, I just changed |
Member
Author
|
@pdimov Thanks. I will update this PR accordingly. |
1. Make inclusion of boost/bind/bind.hpp conditional in some cases, when the code actually conditionally uses boost::bind. Reduces compile-time overhead and fixes boostorg#307. 2. Remove some unnecessary uses of boost::ref. This allows to avoid including boost/core/ref.hpp in a few places, and avoids the associated template instantiation overhead in others. 3. Replace deprecated header includes with the more recent alternatives. For example: boost/detail/lightweight_test.hpp -> boost/core/lightweight_test.hpp, boost/ref.hpp -> boost/core/ref.hpp. 4. Replace some blanket includes with the more fine-grained ones. For example, boost/utility.hpp, boost/atomic.hpp. This reduces compile time overhead. 5. Add some missing includes, for example, boost/core/ref.hpp and boost/type_traits/is_same.hpp. 6. Replace uses of std::is_same with boost::is_same (with the corresponding included header) since the standard type_traits header presence and validity is not tested by the code. Using boost::is_same makes the code more portable.
Lastique
force-pushed
the
fix_bind_warnings
branch
from
df77143 to
ee609e8
Compare
Lastique
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make inclusion of
boost/bind/bind.hppconditional in some cases, when the code actually conditionally usesboost::bind. Reduces compile-time overhead and fixes boost/thread/detail/thread.hpp #includes boost/bind.hpp unconditionally but uses it conditionally #307.Remove some unnecessary uses of
boost::ref. This allows to avoid includingboost/core/ref.hppin a few places, and avoids the associated template instantiation overhead in others.Replace deprecated header includes with the more recent alternatives. For example:
boost/detail/lightweight_test.hpp->boost/core/lightweight_test.hpp,boost/ref.hpp->boost/core/ref.hpp.Replace some blanket includes with the more fine-grained ones. For example,
boost/utility.hpp,boost/atomic.hpp. This reduces compile time overhead.Add some missing includes, for example,
boost/core/ref.hppandboost/type_traits/is_same.hpp.Replace uses of
std::is_samewithboost::is_same(with the corresponding included header) since the standard type_traits header presence and validity is not tested by the code. Usingboost::is_samemakes the code more portable.