Use unsigned char as the underlying type for the tribool state#28
Open
Lastique wants to merge 1 commit intoboostorg:developfrom
Open
Use unsigned char as the underlying type for the tribool state#28Lastique wants to merge 1 commit intoboostorg:developfrom
unsigned char as the underlying type for the tribool state#28Lastique wants to merge 1 commit intoboostorg:developfrom
Conversation
Contributor
|
Note that sizeof(bool) == 4 on most unix systems. |
Member
Author
|
You mean legacy UNIX'es that are now dead? I'm only aware of Solaris on Sparc where this is true. On Linux and, I think, all BSDs, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #28 +/- ##
========================================
Coverage 97.72% 97.72%
========================================
Files 2 2
Lines 132 132
========================================
Hits 129 129
Misses 3 3
Continue to review full report in Codecov by Sentry.
|
Collaborator
|
@Lastique can you rebase on develop to get the full set of CI to run on this? |
This makes sizeof(tribool) == 1, which is similar to sizeof(bool) on most platforms. This is only enabled when C++11 scoped enums are supported.
Lastique
force-pushed
the
feature/reduce_tribool_size
branch
from
d53263d to
6c61a8a
Compare
Member
Author
Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
sizeof(tribool) == 1, which is similar tosizeof(bool)on most platforms. This is only enabled when C++11 scoped enums are supported.