Initial separation of active Span propagation.#2
Open
carlosalberto wants to merge 2 commits intobogdandrutu:big-hookfrom
Open
Initial separation of active Span propagation.#2carlosalberto wants to merge 2 commits intobogdandrutu:big-hookfrom
carlosalberto wants to merge 2 commits intobogdandrutu:big-hookfrom
Conversation
felixbarny
reviewed
Dec 19, 2018
| } | ||
|
|
||
| @Override | ||
| public Scope withSpan(Span span, boolean finishSpanOnClose) { |
There was a problem hiding this comment.
I'm wondering why you introduce the finishSpanOnClose flag here while it has recently been deprecated in OT.
Author
There was a problem hiding this comment.
Good observation ;) I did it to keep the current prototype working (as OC still uses this flag all over the place).
Later on we definitely should deprecate it as well (or remove it ;) )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prototype of separation of the Span propagation logic - the default implementation still uses
io.grpc.Context, and users providing their own would have to provide the equivalent functionality.PS -
ScopeandScopeManagerImplwould need to moved around later on ;)