Support for Object.hasOwn narrowing#71
Draft
gorosgobe wants to merge 1 commit intobloomberg:oss-hackathon-44253from
Draft
Support for Object.hasOwn narrowing#71gorosgobe wants to merge 1 commit intobloomberg:oss-hackathon-44253from
gorosgobe wants to merge 1 commit intobloomberg:oss-hackathon-44253from
Conversation
acutmore
reviewed
Jun 17, 2022
|
|
||
| if (isPropertyAccessExpression(callExpression.expression)) { | ||
| const callAccess = callExpression.expression; | ||
| if (isIdentifier(callAccess.name) && callAccess.name.escapedText === "hasOwn" && callExpression.arguments.length === 2 && isStringLiteralLike(callExpression.arguments[1])) { |
There was a problem hiding this comment.
A downside to special casing the exact names here is that it would break for cases where the function is assigned to a different name:
const hasProp = Object.hasOwn;
if (hasProp(o, 'test')) ...I think instead of adding this logic within the compiler itself, we might be able to do it by updating the .d.ts definitions that are packaged with tsc. Something like:
interface ObjectConstructor {
hasOwn<T, P extends string>(o: T, p: P): o is Extract<T, { [p in P]: unknown }>;
}
There was a problem hiding this comment.
Agreed, it seems like we have the necessary building blocks to express this already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.