[PM-31835] feat: add generator copy password field on send#6508
[PM-31835] feat: add generator copy password field on send#6508
Conversation
…835/add-generator-copy-password-field-on-send
|
Great job! No new security vulnerabilities introduced in this pull request |
|
Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!) But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## PM-31614/update-add-edit-send-ui-email-auth #6508 +/- ##
===============================================================================
- Coverage 86.39% 86.33% -0.07%
===============================================================================
Files 789 794 +5
Lines 56546 56768 +222
Branches 8207 8210 +3
===============================================================================
+ Hits 48853 49008 +155
- Misses 4835 4902 +67
Partials 2858 2858 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
That component is being replaced, this change is to add that same buttons on the new component. |
This reverts commit b3053e4.
…835/add-generator-copy-password-field-on-send # Conflicts: # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt # app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt # app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31835
📔 Objective
Add copy and generator button to the password field on the new send's password AuthType
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes