Skip to content

[PM-31835] feat: add generator copy password field on send#6508

Open
aj-rosado wants to merge 15 commits intomainfrom
PM-31835/add-generator-copy-password-field-on-send
Open

[PM-31835] feat: add generator copy password field on send#6508
aj-rosado wants to merge 15 commits intomainfrom
PM-31835/add-generator-copy-password-field-on-send

Conversation

@aj-rosado
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-31835

📔 Objective

Add copy and generator button to the password field on the new send's password AuthType

📸 Screenshots

Screenshot_1770736912

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@aj-rosado aj-rosado requested review from a team and david-livefront as code owners February 10, 2026 15:27
@github-actions github-actions bot added app:password-manager Bitwarden Password Manager app context app:authenticator Bitwarden Authenticator app context t:feature Change Type - Feature Development labels Feb 10, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 10, 2026

Logo
Checkmarx One – Scan Summary & Details673b428d-8aac-4e36-9e50-2c4e7878d3ef

Great job! No new security vulnerabilities introduced in this pull request

@pamperer562580892423
Copy link

pamperer562580892423 commented Feb 10, 2026

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (4148769) to head (c6c4c87).
⚠️ Report is 1 commits behind head on PM-31614/update-add-edit-send-ui-email-auth.

Additional details and impacted files
@@                               Coverage Diff                               @@
##           PM-31614/update-add-edit-send-ui-email-auth    #6508      +/-   ##
===============================================================================
- Coverage                                        86.39%   86.33%   -0.07%     
===============================================================================
  Files                                              789      794       +5     
  Lines                                            56546    56768     +222     
  Branches                                          8207     8210       +3     
===============================================================================
+ Hits                                             48853    49008     +155     
- Misses                                            4835     4902      +67     
  Partials                                          2858     2858              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aj-rosado aj-rosado changed the base branch from main to PM-31614/update-add-edit-send-ui-email-auth February 10, 2026 18:52
@aj-rosado
Copy link
Contributor Author

Sorry, nosy user alert. But as I tracked this, I think there already was a fix for this: #6435 (PS: or maybe that was on a component that now gets replaced?!)

But as this #6505 just was reported, it seems to miss the usual "Check password for data breaches" button directly below / attached to that password field. (BTW, like also in your screenshot @aj-rosado)

That component is being replaced, this change is to add that same buttons on the new component.
Thank you for being aware and raising this 👍

…835/add-generator-copy-password-field-on-send

# Conflicts:
#	app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendContent.kt
#	app/src/main/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/components/AddEditSendAuthTypeChooser.kt
#	app/src/test/kotlin/com/x8bit/bitwarden/ui/tools/feature/send/addedit/AddEditSendScreenTest.kt
@github-actions github-actions bot removed the app:authenticator Bitwarden Authenticator app context label Feb 13, 2026
Base automatically changed from PM-31614/update-add-edit-send-ui-email-auth to main February 13, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants